Add support for break if #1993
Merged
Add support for break if #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly is changing the formatting of some parts, and if those changes are formatted with stable they are reverted |
jimblandy
requested changes
Jun 21, 2022
There was a problem hiding this comment.
Thank you so much for 1) this PR and 2) leaving the SPIR-V front end change to a separate PR so my brain doesn't break.
This also needs some failure case coverage in tests/wgsl-errors.rs:
- misplaced
break ifstatements - non-
boolexpressions
A few suggestions, too.
jimblandy
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
break ifstatement that may appear in thecontinuingblock of a loop.Relevant part of the spec: https://gpuweb.github.io/gpuweb/wgsl/#break-if-statement
Implements parsing in the wgsl frontend, emission on all the backends and validation for it.
Uniformity analysis isn't implemented, following the same behavior as regular breaks (this will be fixed in the uniformity analysis v5 rewrite).
All commits can be reviewed individually and are fully tested
Closes #1831